fix side effects of messing with catalyst_component_name

[catagits/Catalyst-Runtime.git] / TODO

diff --git a/TODO b/TODO
index 8490d57..da1026d 100644 (file)
--- a/TODO
+++ b/TODO
@@ -57,8 +57,27 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree
 
 ## GSOC
 
+### Final steps for GSOC
+
+##### Things that work:
+
+##### Things that don't work:
+
+##### Need planning, have questions:
+
 ### Next steps - planned:
 
+  - some imports need to get the importing package in Catalyst::IOC
+
+  - test values directly instead of serializing them over http in t/lib/TestCustomContainer.pm
+
+  - 16:01 < shadowpaste> "t0m" at 217.168.150.38 pasted "more explicit? thoughts?" (13 lines) at http://paste.scsys.co.uk/131520
+
+  - make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection
+    - Create COMPONENTSingleton life cycle
+
+  - Back compat for Catalyst.pm moved methods (locate_components)
+
   - Test custom container
     - writing some tests which verify that the models you think should be
       there are there, and that they received their dependencies as arguments
@@ -70,12 +89,6 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree
       $c->model('Foo'), and that COMPONENT is called (or not called)
       as appropiate and that ACCEPT_CONTEXT is called (or not) as appropriate
 
-  - Kill flush_request_services
-    - we're already passing $ctx in when we locate services so the ::Request
-      lifecycle can just stash the object in, or retrieve the object from the
-      stash
-      (actually, we're not passing $ctx when we locate services. Problem!)
-
 ### Next steps - less planned:
 
   - Creating service()-like sugar for component
@@ -123,29 +136,6 @@ use Catalyst::IOC;
 
 1;
 
-##### To start with
-
-package MyApp::Container;
-use Moose;
-
-extends 'Catalyst::Container;
-
-after BUILD => sub {
-    my $self = shift;
-    my $model_container = $self->get_sub_container('model');
-    my $service = Catalyst::IOC::ConstructorInjection->new(
-        name      => 'Baz',
-        class     => 'MyApp::Model::Baz',
-        dependencies => [
-            depends_on( '/application_name' ),
-            depends_on( '/config' ),
-            depends_on( '/model/Foo' ),
-        ],
-        lifecycle => 'InstancePerContext',
-    );
-    $model_container->add_service( 'Foo', $service );
-};
-
 ### To polish off / t0m review
 
     locate_components service vs setup_components method
@@ -153,14 +143,6 @@ after BUILD => sub {
       - should setup_components be a service that things like the ->component lookup
         can depend on?
 
-    -    my $accept_context_args = $self->param('accept_context_args');
-    +    my $accept_context_args = $params{accept_context_args};
-    ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the 
-       accept_context args, no?
-       Without this change, the user could make a custom service which mangled the param, and use 
-       Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the
-       un-mangled version?? However, without this change, shit doesn't work...
-
 ### Known issues
 
     - Broken $instance->expand_modules() in setup_components and figure