Fix Makefile.PL if you have really really old CPAN.pm and you're not trying to -...

[p5sagit/local-lib.git] / Makefile.PL

diff --git a/Makefile.PL b/Makefile.PL
index cf1ec5c..d232325 100644 (file)
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -1,8 +1,13 @@
 use strict;
 use warnings;
-use vars qw($bootstrapping);
+use File::Spec;
+use Cwd;
+use vars qw($bootstrapping $bootstrapping_args);
+use Config;
 
+my $cwd;
 BEGIN {
+  $cwd = Cwd::cwd();
   # watch out for fancy dashes. these can wind up in our @ARGV if the user is
   # copypasting the bootstrap command from the POD displayed e.g. by perldoc
   # on a Mac OS X terminal. since no software recognizes and handles these
@@ -22,8 +27,8 @@ DEATH
   if (my ($x) = grep { /^--bootstrap(?:=.*)?$/ } @ARGV) {
     @ARGV = grep { !/^--bootstrap(?:=.*)?$/ } @ARGV;
     $bootstrapping = 1;
-    $x =~ /^--bootstrap(?:=(.*))?$/;
-    my @args = (defined $1 ? ($1) : ());
+    my ($path) = $x =~ /^--bootstrap(?:=(.*))?$/;
+    my @args = $path ? $path : ();
 
     {
       local @INC = @INC;
@@ -33,8 +38,10 @@ DEATH
 
     local::lib->import(@args);
 
+    my @libs = map { "-I$_" } split $Config{path_sep}, $ENV{PERL5LIB};
+    $bootstrapping_args = "@libs";
     push(@ARGV,$ENV{PERL_MM_OPT});
-    push(@ARGV, map { "-I$_" } split(':',$ENV{PERL5LIB}));
+    push(@ARGV, @libs);
 
     system($^X, '-MExtUtils::MakeMaker 6.31', '-e1');
     my $eumm = $? >> 8;
@@ -46,7 +53,7 @@ DEATH
     system($^X, '-MCPAN', '-e',
       'my $done; require ExtUtils::MakeMaker;
        my $orig = ExtUtils::MakeMaker->can("prompt");
-       *ExtUtils::MakeMaker::prompt = sub {
+       *ExtUtils::MakeMaker::prompt = sub ($;$) {
          if (!$done && $_[0] =~ /manual configuration/) {
            $done++;
            return "no";
@@ -78,6 +85,8 @@ DEATH
     if ($cpan) {
       system($^X, '-MCPAN', '-e', 'CPAN::Config->load; CPAN::Config->commit;');
     }
+
+    chdir($cwd);
   }
 }
 
@@ -90,7 +99,8 @@ requires 'ExtUtils::MakeMaker' => '6.31'; # version INSTALL_BASE was added
 requires 'ExtUtils::CBuilder'; # this and ParseXS are needed for MB C_support
 requires 'ExtUtils::ParseXS';
 requires 'Module::Build' => '0.28'; # lib -> lib/perl5 change
-requires 'CPAN' => '1.80'; # sudo support
+my $required_CPAN = '1.80';
+requires 'CPAN' => $required_CPAN; # sudo support + CPAN::HandleConfig
 
 # No, really. See
 # https://rt.cpan.org/Public/Bug/Display.html?id=23735
@@ -99,13 +109,52 @@ requires 'CPAN' => '1.80'; # sudo support
 # without this beautiful hack
 
 my $no_cpanplus_env = !exists $ENV{PERL5_CPANPLUS_IS_RUNNING};
+my $no_cpan_env = !exists $ENV{PERL5_CPAN_IS_RUNNING};
 require CPAN;
 delete $ENV{PERL5_CPANPLUS_IS_RUNNING} if $no_cpanplus_env;
+delete $ENV{PERL5_CPAN_IS_RUNNING} if $no_cpan_env;
+
+# and make sure that the user doesn't have any existing CPAN config that'll
+# cause us problems for the next few steps.
+{
+    local $@;
+    eval { require CPAN::HandleConfig; };
+    # Need newish CPAN.pm for this, ergo skip it if that version of CPAN isn't
+    # installed yet.
+    # It will already be installed by the time we reach here if bootstrapping,
+    # otherwise, if we're running from CPAN then it will be installed soon
+    # enough, and we'll come back here..
+    if (!$@) {
+        CPAN::HandleConfig->load;
+        for my $eumm_setting ( qw/makepl_arg make_install_arg/ ) {
+            if ($CPAN::Config->{$eumm_setting} =~ /(?:PREFIX|INSTALL_BASE)/) {
+                die "Possibly invalid config detected in $eumm_setting: " . $CPAN::Config->{$eumm_setting};
+            }
+        }
+
+        for my $mb_setting (qw/mbuild_arg mbuild_install_arg mbuildpl_arg/) {
+            if ($CPAN::Config->{$mb_setting} =~ /(?:--prefix|--install_base)/) {
+                die "Possibly invalid config detected in $mb_setting: " . $CPAN::Config->{$mb_setting};
+            }
+        }
+    }
+    else {
+        my $error = $@;
+        require CPAN;
+        # Explode if it looks like requiring CPAN::HandleConfig should
+        # have worked, but didn't.
+        die($error) if $CPAN::VERSION >= $required_CPAN;
+    }
+}
 
 if ($bootstrapping) {
   auto_install_now;
+  postamble <<"END";
+PERL     += $bootstrapping_args
+FULLPERL += $bootstrapping_args
+END
 } else {
   auto_install;
 }
-
+chdir($cwd);
 WriteAll;