remove test dependency on Test::Without::Module (RT#115394)

[p5sagit/JSON-MaybeXS.git] / Makefile.PL

diff --git a/Makefile.PL b/Makefile.PL
index 8dbcd06..a2e1a60 100644 (file)
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -11,10 +11,14 @@ my %WriteMakefileArgs = (
     'meta-spec' => { version => 2 },
     dynamic_config => 1,
     resources => {
-    # r/w: p5sagit@git.shadowcat.co.uk:JSON-MaybeXS.git
+      # GitHub mirrors from Shadowcat. We list it so we can get pull requests.
+      # The canonical repo is:
+      # r/o: git://git.shadowcat.co.uk/p5sagit/JSON-MaybeXS.git
+      # r/w: p5sagit@git.shadowcat.co.uk:JSON-MaybeXS.git
+      # web: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/JSON-MaybeXS.git
       repository => {
-        url => 'git://git.shadowcat.co.uk/p5sagit/JSON-MaybeXS.git',
-        web => 'http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/JSON-MaybeXS.git',
+        url => 'https://github.com/p5sagit/JSON-MaybeXS.git',
+        web => 'https://github.com/p5sagit/JSON-MaybeXS',
         type => 'git',
       },
       bugtracker => {
@@ -56,7 +60,6 @@ my %WriteMakefileArgs = (
       },
       test => {
         requires => {
-          'Test::Without::Module' => '0.17',
           'Test::More' => '0.88',
         },
       },
@@ -85,20 +88,13 @@ if (not $args->{PUREPERL_ONLY}) {
     # we require Cpanel::JSON::XS, except if JSON::XS is already installed.
     # (we also always recommend Cpanel::JSON::XS, just to make sure.)
     $WriteMakefileArgs{PREREQ_PM}{'Cpanel::JSON::XS'} = '2.3310'
-        if (eval { require Cpanel::JSON::XS; 1 } and not eval { Cpanel::JSON::XS->VERSION('2.3310'); 1 })
+        if eval { require Cpanel::JSON::XS; 1 }
             or (not eval { require JSON::XS; 1; } and can_xs());
 
-    # avoid "JSON::XS::Boolean::* redefined" warnings caused by incompatibilities
-    # between JSON::XS 2.x and 3.0 --
+    # JSON::XS 3 changed its boolean handling - update it
     # if JSON::XS is installed and < 3.0
-    # and Cpanel::JSON::XS is (or is about to be) >= 3.0,
-    # then update JSON::XS to eliminate the incompatibility
     $WriteMakefileArgs{PREREQ_PM}{'JSON::XS'} = '3.00'
-        if eval { require JSON::XS; 1 } and not eval { JSON::XS->VERSION('3.0'); 1 }
-            and (eval { require Cpanel::JSON::XS; Cpanel::JSON::XS->VERSION('3.0'); 1 }
-                # we presume here that if we are installing Cpanel::JSON::XS, we
-                # are installing the latest version
-                or exists $WriteMakefileArgs{PREREQ_PM}{'Cpanel::JSON::XS'});
+        if eval { require JSON::XS; 1 } and not eval { JSON::XS->VERSION('3.0'); 1 };
 }
 
 $WriteMakefileArgs{MIN_PERL_VERSION} = delete $WriteMakefileArgs{PREREQ_PM}{perl} || 0;