7 use SQL::Abstract::Test import => ['is_same_sql_bind'];
10 use Storable qw/dclone/;
14 Test -and -or and -nest modifiers, assuming the following:
16 * Modifiers are respected in both hashrefs and arrayrefs (with the obvious
17 limitation of one modifier type per hahsref)
18 * When in condition context i.e. where => { -or { a = 1 } }, each modifier
19 affects only the immediate element following it.
20 * When in column multi-condition context i.e.
21 where => { x => { '!=', [-and, [qw/1 2 3/]] } }, a modifier affects the
22 OUTER ARRAYREF if and only if it is the first element of said ARRAYREF
26 # no warnings (the -or/-and => { } warning is silly, there is nothing wrong with such usage)
28 and => { stmt => 'WHERE a = ? AND b = ?', bind => [qw/1 2/] },
29 or => { stmt => 'WHERE a = ? OR b = ?', bind => [qw/1 2/] },
30 or_and => { stmt => 'WHERE ( foo = ? OR bar = ? ) AND baz = ? ', bind => [qw/1 2 3/] },
31 or_or => { stmt => 'WHERE foo = ? OR bar = ? OR baz = ?', bind => [qw/1 2 3/] },
32 and_or => { stmt => 'WHERE ( foo = ? AND bar = ? ) OR baz = ?', bind => [qw/1 2 3/] },
38 where => { -and => [a => 1, b => 2] },
39 %{$and_or_args->{and}},
42 where => [ -and => [a => 1, b => 2] ],
43 %{$and_or_args->{and}},
46 where => { -or => [a => 1, b => 2] },
47 %{$and_or_args->{or}},
50 where => [ -or => [a => 1, b => 2] ],
51 %{$and_or_args->{or}},
55 where => { -and => {a => 1, b => 2} },
56 %{$and_or_args->{and}},
59 where => [ -and => {a => 1, b => 2} ],
60 %{$and_or_args->{and}},
63 where => { -or => {a => 1, b => 2} },
64 %{$and_or_args->{or}},
67 where => [ -or => {a => 1, b => 2} ],
68 %{$and_or_args->{or}},
71 # test modifiers within hashrefs
74 [ foo => 1, bar => 2 ],
77 %{$and_or_args->{or_or}},
81 [ foo => 1, bar => 2 ],
84 %{$and_or_args->{or_and}},
87 # test modifiers within arrayrefs
90 [ foo => 1, bar => 2 ],
93 %{$and_or_args->{or_or}},
97 [ foo => 1, bar => 2 ],
100 %{$and_or_args->{or_and}},
103 # test ambiguous modifiers within hashrefs (op extends to to immediate RHS only)
105 where => { -and => [ -or =>
106 [ foo => 1, bar => 2 ],
109 %{$and_or_args->{or_and}},
112 where => { -or => [ -and =>
113 [ foo => 1, bar => 2 ],
116 %{$and_or_args->{and_or}},
119 # test ambiguous modifiers within arrayrefs (op extends to to immediate RHS only)
121 where => [ -and => [ -or =>
122 [ foo => 1, bar => 2 ],
125 %{$and_or_args->{or_and}},
128 where => [ -or => [ -and =>
129 [ foo => 1, bar => 2 ],
132 %{$and_or_args->{and_or}},
135 # test column multi-cond in arrayref (useless example)
137 where => { x => [ -and => (1 .. 3) ] },
138 stmt => 'WHERE x = ? AND x = ? AND x = ?',
141 # test column multi-cond in arrayref (more useful)
143 where => { x => [ -and => {'!=' => 1}, {'!=' => 2}, {'!=' => 3} ] },
144 stmt => 'WHERE x != ? AND x != ? AND x != ?',
147 # test column multi-cond in arrayref (even more useful)
149 where => { x => { '!=' => [ -and => (1 .. 3) ] } },
150 stmt => 'WHERE x != ? AND x != ? AND x != ?',
154 # the -or should affect only the inner hashref, as we are not in an outer arrayref
157 -or => { '!=', 1, '>=', 2 }, -like => 'x%'
159 stmt => 'WHERE x LIKE ? AND ( x != ? OR x >= ? )',
160 bind => [qw/x% 1 2/],
163 # the -and should affect the OUTER arrayref, while the internal structures remain intact
166 -and => [ 1, 2 ], { -like => 'x%' }
168 stmt => 'WHERE (x = ? OR x = ?) AND x LIKE ?',
169 bind => [qw/1 2 x%/],
173 where => { -and => [a => 1, b => 2], x => 9, -or => { c => 3, d => 4 } },
174 stmt => 'WHERE a = ? AND b = ? AND ( c = ? OR d = ? ) AND x = ?',
175 bind => [qw/1 2 3 4 9/],
179 where => { -and => [a => 1, b => 2, k => [11, 12] ], x => 9, -or => { c => 3, d => 4, l => { '=' => [21, 22] } } },
180 stmt => 'WHERE a = ? AND b = ? AND (k = ? OR k = ?) AND (c = ? OR d = ? OR (l = ? OR l = ?) ) AND x = ?',
181 bind => [qw/1 2 11 12 3 4 21 22 9/],
185 where => { -or => [a => 1, b => 2, k => [11, 12] ], x => 9, -and => { c => 3, d => 4, l => { '=' => [21, 22] } } },
186 stmt => 'WHERE c = ? AND d = ? AND ( l = ? OR l = ?) AND (a = ? OR b = ? OR k = ? OR k = ?) AND x = ?',
187 bind => [qw/3 4 21 22 1 2 11 12 9/],
191 where => [ -or => [a => 1, b => 2], -or => { c => 3, d => 4}, e => 5, -and => [ f => 6, g => 7], [ h => 8, i => 9, -and => [ k => 10, l => 11] ], { m => 12, n => 13 }],
192 stmt => 'WHERE a = ? OR b = ? OR c = ? OR d = ? OR e = ? OR ( f = ? AND g = ?) OR h = ? OR i = ? OR ( k = ? AND l = ? ) OR (m = ? AND n = ?)',
197 # explicit OR logic in arrays should leave everything intact
198 args => { logic => 'or' },
199 where => { -and => [a => 1, b => 2, k => [11, 12] ], x => 9, -or => { c => 3, d => 4, l => { '=' => [21, 22] } } },
200 stmt => 'WHERE a = ? AND b = ? AND (k = ? OR k = ?) AND ( c = ? OR d = ? OR l = ? OR l = ? ) AND x = ? ',
201 bind => [qw/1 2 11 12 3 4 21 22 9/],
205 # flip logic in arrays except where excplicitly requested otherwise
206 args => { logic => 'and' },
207 where => [ -or => [a => 1, b => 2], -or => { c => 3, d => 4}, e => 5, -and => [ f => 6, g => 7], [ h => 8, i => 9, -and => [ k => 10, l => 11] ], { m => 12, n => 13 }],
208 stmt => 'WHERE (a = ? OR b = ?) AND (c = ? OR d = ?) AND e = ? AND f = ? AND g = ? AND h = ? AND i = ? AND k = ? AND l = ? AND m = ? AND n = ?',
212 # 1st -and is in column mode, thus flips the entire array, whereas the
213 # 2nd one is just a condition modifier
216 col => [ -and => {'<' => 123}, {'>' => 456 }, {'!=' => 789} ],
218 col2 => [ -or => { -like => 'crap' }, { -like => 'crop' } ],
219 col3 => [ -and => { -like => 'chap' }, { -like => 'chop' } ],
223 (col < ? AND col > ? AND col != ?)
226 ( col2 LIKE ? OR col2 LIKE ? )
228 ( col3 LIKE ? AND col3 LIKE ? )
231 bind => [qw/123 456 789 crap crop chap chop/],
235 # some corner cases by ldami (some produce useless SQL, just for clarification on 1.5 direction)
240 -and => [ { -like => 'foo%'}, {'>' => 'moo'} ],
241 { -like => '%bar', '<' => 'baz'},
242 [ {-like => '%alpha'}, {-like => '%beta'} ],
243 [ {'!=' => 'toto', '=' => 'koko'} ],
245 stmt => 'WHERE (foo LIKE ? OR foo > ?) AND (foo LIKE ? AND foo < ?) AND (foo LIKE ? OR foo LIKE ?) AND (foo != ? AND foo = ?)',
246 bind => [qw/foo% moo %bar baz %alpha %beta toto koko/],
251 -and => [a => 1, b => 2],
252 -or => [c => 3, d => 4],
253 e => [-and => {-like => 'foo%'}, {-like => '%bar'} ],
255 stmt => 'WHERE (a = ? AND b = ?) OR c = ? OR d = ? OR (e LIKE ? AND e LIKE ?)',
256 bind => [qw/1 2 3 4 foo% %bar/],
259 # -or has nothing to flip
261 where => [-and => [{foo => 1}, {bar => 2}, -or => {baz => 3}] ],
262 stmt => 'WHERE foo = ? AND bar = ? AND baz = ?',
266 where => [-and => [{foo => 1}, {bar => 2}, -or => {baz => 3, woz => 4} ] ],
267 stmt => 'WHERE foo = ? AND bar = ? AND (baz = ? OR woz = ?)',
271 # -and has only 1 following element, thus all still ORed
273 where => { col => [ -and => [{'<' => 123}, {'>' => 456 }, {'!=' => 789}] ] },
274 stmt => 'WHERE col < ? OR col > ? OR col != ?',
275 bind => [qw/123 456 789/],
278 # flipping array logic affects both column value and condition arrays
280 args => { logic => 'and' },
281 where => [ col => [ {'<' => 123}, {'>' => 456 }, {'!=' => 789} ], col2 => 0 ],
282 stmt => 'WHERE col < ? AND col > ? AND col != ? AND col2 = ?',
283 bind => [qw/123 456 789 0/],
286 # flipping array logic with explicit -and works
288 args => { logic => 'and' },
289 where => [ col => [ -and => {'<' => 123}, {'>' => 456 }, {'!=' => 789} ], col2 => 0 ],
290 stmt => 'WHERE col < ? AND col > ? AND col != ? AND col2 = ?',
291 bind => [qw/123 456 789 0/],
293 # flipping array logic with explicit -or flipping it back
295 args => { logic => 'and' },
296 where => [ col => [ -or => {'<' => 123}, {'>' => 456 }, {'!=' => 789} ], col2 => 0 ],
297 stmt => 'WHERE (col < ? OR col > ? OR col != ?) AND col2 = ?',
298 bind => [qw/123 456 789 0/],
302 # modN and mod_N were a bad design decision - they go away in SQLA2, warn now
303 my @numbered_mods = (
306 -and => [a => 10, b => 11],
307 -and2 => [ c => 20, d => 21 ],
309 -nest2 => [ y => 2 ],
310 -or => { m => 7, n => 8 },
311 -or2 => { m => 17, n => 18 },
313 correct => { -and => [
314 -and => [a => 10, b => 11],
315 -and => [ c => 20, d => 21 ],
318 -or => { m => 7, n => 8 },
319 -or => { m => 17, n => 18 },
324 -and2 => [a => 10, b => 11],
325 -and_3 => [ c => 20, d => 21 ],
326 -nest2 => [ x => 1 ],
327 -nest_3 => [ y => 2 ],
328 -or2 => { m => 7, n => 8 },
329 -or_3 => { m => 17, n => 18 },
331 correct => [ -and => [
332 -and => [a => 10, b => 11],
333 -and => [ c => 20, d => 21 ],
336 -or => { m => 7, n => 8 },
337 -or => { m => 17, n => 18 },
344 where => {a => 1, -nest => [b => 2, c => 3]},
345 stmt => 'WHERE ( ( (b = ? OR c = ?) AND a = ? ) )',
349 where => {a => 1, -nest => {b => 2, c => 3}},
350 stmt => 'WHERE ( ( (b = ? AND c = ?) AND a = ? ) )',
354 where => {a => 1, -or => {-nest => {b => 2, c => 3}}},
355 stmt => 'WHERE ( ( (b = ? AND c = ?) AND a = ? ) )',
359 where => {a => 1, -or => {-nest => [b => 2, c => 3]}},
360 stmt => 'WHERE ( ( (b = ? OR c = ?) AND a = ? ) )',
364 where => {a => 1, -nest => {-or => {b => 2, c => 3}}},
365 stmt => 'WHERE ( ( (b = ? OR c = ?) AND a = ? ) )',
369 where => [a => 1, -nest => {b => 2, c => 3}, -nest => [d => 4, e => 5]],
370 stmt => 'WHERE ( ( a = ? OR ( b = ? AND c = ? ) OR ( d = ? OR e = ? ) ) )',
371 bind => [qw/1 2 3 4 5/],
375 plan tests => @and_or_tests*4 + @numbered_mods*4 + @nest_tests*2;
377 for my $case (@and_or_tests) {
379 local $TODO = $case->{todo} if $case->{todo};
381 local $Data::Dumper::Terse = 1;
384 local $SIG{__WARN__} = sub { push @w, @_ };
386 my $sql = SQL::Abstract->new ($case->{args} || {});
387 my $where_copy = dclone($case->{where});
390 my ($stmt, @bind) = $sql->where($case->{where});
397 || diag "Search term:\n" . Dumper $case->{where};
399 is (@w, 0, 'No warnings within and-or tests')
400 || diag join "\n", 'Emitted warnings:', @w;
402 is_deeply ($case->{where}, $where_copy, 'Where conditions unchanged');
406 for my $case (@nest_tests) {
408 local $TODO = $case->{todo} if $case->{todo};
410 local $SQL::Abstract::Test::parenthesis_significant = 1;
411 local $Data::Dumper::Terse = 1;
413 my $sql = SQL::Abstract->new ($case->{args} || {});
415 my ($stmt, @bind) = $sql->where($case->{where});
422 || diag "Search term:\n" . Dumper $case->{where};
429 my $w_str = "\QUse of [and|or|nest]_N modifiers is deprecated and will be removed in SQLA v2.0\E";
430 for my $case (@numbered_mods) {
432 local $TODO = $case->{todo} if $case->{todo};
434 local $Data::Dumper::Terse = 1;
437 local $SIG{__WARN__} = sub { push @w, @_ };
438 my $sql = SQL::Abstract->new ($case->{args} || {});
440 my ($old_s, @old_b) = $sql->where($case->{backcompat});
441 my ($new_s, @new_b) = $sql->where($case->{correct});
445 'Backcompat and the correct(tm) syntax result in identical statements',
446 ) || diag "Search terms:\n" . Dumper {
447 backcompat => $case->{backcompat},
448 correct => $case->{correct},
452 ok (@w, 'Warnings were emitted about a mod_N construct');
456 push @non_match, $_ if ($_ !~ /$w_str/);
459 is (@non_match, 0, 'All warnings match the deprecation message')
460 || diag join "\n", 'Rogue warnings:', @non_match;