7 use SQL::Abstract::Test import => ['is_same_sql_bind'];
13 Test -and -or and -nest modifiers, assuming the following:
15 * Modifiers are respected in both hashrefs and arrayrefs (with the obvious
16 limitation of one modifier type per hahsref)
17 * When in condition context i.e. where => { -or { a = 1 } }, each modifier
18 affects only the immediate element following it.
19 * When in column multi-condition context i.e.
20 where => { x => { '!=', [-and, [qw/1 2 3/]] } }, a modifier affects the
21 OUTER ARRAYREF if and only if it is the first element of said ARRAYREF
25 # no warnings (the -or/-and => { } warning is silly, there is nothing wrong with such usage)
27 and => { stmt => 'WHERE a = ? AND b = ?', bind => [qw/1 2/] },
28 or => { stmt => 'WHERE a = ? OR b = ?', bind => [qw/1 2/] },
29 or_and => { stmt => 'WHERE ( foo = ? OR bar = ? ) AND baz = ? ', bind => [qw/1 2 3/] },
30 or_or => { stmt => 'WHERE foo = ? OR bar = ? OR baz = ?', bind => [qw/1 2 3/] },
31 and_or => { stmt => 'WHERE ( foo = ? AND bar = ? ) OR baz = ?', bind => [qw/1 2 3/] },
37 where => { -and => [a => 1, b => 2] },
38 %{$and_or_args->{and}},
41 where => [ -and => [a => 1, b => 2] ],
42 %{$and_or_args->{and}},
45 where => { -or => [a => 1, b => 2] },
46 %{$and_or_args->{or}},
49 where => [ -or => [a => 1, b => 2] ],
50 %{$and_or_args->{or}},
54 where => { -and => {a => 1, b => 2} },
55 %{$and_or_args->{and}},
58 where => [ -and => {a => 1, b => 2} ],
59 %{$and_or_args->{and}},
62 where => { -or => {a => 1, b => 2} },
63 %{$and_or_args->{or}},
66 where => [ -or => {a => 1, b => 2} ],
67 %{$and_or_args->{or}},
70 # test modifiers within hashrefs
73 [ foo => 1, bar => 2 ],
76 %{$and_or_args->{or_or}},
80 [ foo => 1, bar => 2 ],
83 %{$and_or_args->{or_and}},
86 # test modifiers within arrayrefs
89 [ foo => 1, bar => 2 ],
92 %{$and_or_args->{or_or}},
96 [ foo => 1, bar => 2 ],
99 %{$and_or_args->{or_and}},
102 # test ambiguous modifiers within hashrefs (op extends to to immediate RHS only)
104 where => { -and => [ -or =>
105 [ foo => 1, bar => 2 ],
108 %{$and_or_args->{or_and}},
111 where => { -or => [ -and =>
112 [ foo => 1, bar => 2 ],
115 %{$and_or_args->{and_or}},
118 # test ambiguous modifiers within arrayrefs (op extends to to immediate RHS only)
120 where => [ -and => [ -or =>
121 [ foo => 1, bar => 2 ],
124 %{$and_or_args->{or_and}},
127 where => [ -or => [ -and =>
128 [ foo => 1, bar => 2 ],
131 %{$and_or_args->{and_or}},
134 # test column multi-cond in arrayref (useless example)
136 where => { x => [ -and => (1 .. 3) ] },
137 stmt => 'WHERE x = ? AND x = ? AND x = ?',
140 # test column multi-cond in arrayref (more useful)
142 where => { x => [ -and => {'!=' => 1}, {'!=' => 2}, {'!=' => 3} ] },
143 stmt => 'WHERE x != ? AND x != ? AND x != ?',
146 # test column multi-cond in arrayref (even more useful)
148 # todo => 'Clarify semantics in 1.52',
149 where => { x => { '!=' => [ -and => (1 .. 3) ] } },
150 stmt => 'WHERE x != ? AND x != ? AND x != ?',
154 # the -or should affect only the inner hashref, as we are not in an outer arrayref
156 # todo => 'Clarify semantics in 1.52',
158 -or => { '!=', 1, '>=', 2 }, -like => 'x%'
160 stmt => 'WHERE (x != ? OR x >= ?) AND x LIKE ?',
161 bind => [qw/1 2 x%/],
164 # the -and should affect the OUTER arrayref, while the internal structures remain intact
167 -and => [ 1, 2 ], { -like => 'x%' }
169 stmt => 'WHERE (x = ? OR x = ?) AND x LIKE ?',
170 bind => [qw/1 2 x%/],
174 where => { -and => [a => 1, b => 2], x => 9, -or => { c => 3, d => 4 } },
175 stmt => 'WHERE a = ? AND b = ? AND ( c = ? OR d = ? ) AND x = ?',
176 bind => [qw/1 2 3 4 9/],
180 where => { -and => [a => 1, b => 2, k => [11, 12] ], x => 9, -or => { c => 3, d => 4, l => { '=' => [21, 22] } } },
181 stmt => 'WHERE a = ? AND b = ? AND (k = ? OR k = ?) AND ((l = ? OR l = ?) OR c = ? OR d = ? ) AND x = ?',
182 bind => [qw/1 2 11 12 21 22 3 4 9/],
186 where => { -or => [a => 1, b => 2, k => [11, 12] ], x => 9, -and => { c => 3, d => 4, l => { '=' => [21, 22] } } },
187 stmt => 'WHERE c = ? AND d = ? AND ( l = ? OR l = ?) AND (a = ? OR b = ? OR k = ? OR k = ?) AND x = ?',
188 bind => [qw/3 4 21 22 1 2 11 12 9/],
192 where => [ -or => [a => 1, b => 2], -or => { c => 3, d => 4}, e => 5, -and => [ f => 6, g => 7], [ h => 8, i => 9, -and => [ k => 10, l => 11] ], { m => 12, n => 13 }],
193 stmt => 'WHERE a = ? OR b = ? OR c = ? OR d = ? OR e = ? OR ( f = ? AND g = ?) OR h = ? OR i = ? OR ( k = ? AND l = ? ) OR (m = ? AND n = ?)',
198 # explicit OR logic in arrays should leave everything intact
199 args => { logic => 'or' },
200 where => { -and => [a => 1, b => 2, k => [11, 12] ], x => 9, -or => { c => 3, d => 4, l => { '=' => [21, 22] } } },
201 stmt => 'WHERE a = ? AND b = ? AND (k = ? OR k = ?) AND ( l = ? OR l = ? OR c = ? OR d = ? ) AND x = ? ',
202 bind => [qw/1 2 11 12 21 22 3 4 9/],
206 # flip logic in arrays except where excplicitly requested otherwise
207 args => { logic => 'and' },
208 where => [ -or => [a => 1, b => 2], -or => { c => 3, d => 4}, e => 5, -and => [ f => 6, g => 7], [ h => 8, i => 9, -and => [ k => 10, l => 11] ], { m => 12, n => 13 }],
209 stmt => 'WHERE (a = ? OR b = ?) AND (c = ? OR d = ?) AND e = ? AND f = ? AND g = ? AND h = ? AND i = ? AND k = ? AND l = ? AND m = ? AND n = ?',
213 # 1st -and is in column mode, thus flips the entire array, whereas the
214 # 2nd one is just a condition modifier
217 col => [ -and => {'<' => 123}, {'>' => 456 }, {'!=' => 789} ],
219 col2 => [ -or => { -like => 'crap' }, { -like => 'crop' } ],
220 col3 => [ -and => { -like => 'chap' }, { -like => 'chop' } ],
224 (col < ? AND col > ? AND col != ?)
227 ( col2 LIKE ? OR col2 LIKE ? )
229 ( col3 LIKE ? AND col3 LIKE ? )
232 bind => [qw/123 456 789 crap crop chap chop/],
236 # some corner cases by ldami (some produce useless SQL, just for clarification on 1.5 direction)
241 -and => [ { -like => 'foo%'}, {'>' => 'moo'} ],
242 { -like => '%bar', '<' => 'baz'},
243 [ {-like => '%alpha'}, {-like => '%beta'} ],
244 [ {'!=' => 'toto', '=' => 'koko'} ],
246 stmt => 'WHERE (foo LIKE ? OR foo > ?) AND (foo LIKE ? AND foo < ?) AND (foo LIKE ? OR foo LIKE ?) AND (foo != ? AND foo = ?)',
247 bind => [qw/foo% moo %bar baz %alpha %beta toto koko/],
252 -and => [a => 1, b => 2],
253 -or => [c => 3, d => 4],
254 e => [-and => {-like => 'foo%'}, {-like => '%bar'} ],
256 stmt => 'WHERE (a = ? AND b = ?) OR c = ? OR d = ? OR (e LIKE ? AND e LIKE ?)',
257 bind => [qw/1 2 3 4 foo% %bar/],
260 # -or has nothing to flip
262 where => [-and => [{foo => 1}, {bar => 2}, -or => {baz => 3}] ],
263 stmt => 'WHERE foo = ? AND bar = ? AND baz = ?',
267 where => [-and => [{foo => 1}, {bar => 2}, -or => {baz => 3, woz => 4} ] ],
268 stmt => 'WHERE foo = ? AND bar = ? AND (baz = ? OR woz = ?)',
272 # -and has only 1 following element, thus all still ORed
274 where => { col => [ -and => [{'<' => 123}, {'>' => 456 }, {'!=' => 789}] ] },
275 stmt => 'WHERE col < ? OR col > ? OR col != ?',
276 bind => [qw/123 456 789/],
279 # flipping array logic affects both column value and condition arrays
281 args => { logic => 'and' },
282 where => [ col => [ {'<' => 123}, {'>' => 456 }, {'!=' => 789} ], col2 => 0 ],
283 stmt => 'WHERE col < ? AND col > ? AND col != ? AND col2 = ?',
284 bind => [qw/123 456 789 0/],
287 # flipping array logic with explicit -and works
289 args => { logic => 'and' },
290 where => [ col => [ -and => {'<' => 123}, {'>' => 456 }, {'!=' => 789} ], col2 => 0 ],
291 stmt => 'WHERE col < ? AND col > ? AND col != ? AND col2 = ?',
292 bind => [qw/123 456 789 0/],
294 # flipping array logic with explicit -or flipping it back
296 args => { logic => 'and' },
297 where => [ col => [ -or => {'<' => 123}, {'>' => 456 }, {'!=' => 789} ], col2 => 0 ],
298 stmt => 'WHERE (col < ? OR col > ? OR col != ?) AND col2 = ?',
299 bind => [qw/123 456 789 0/],
303 # modN and mod_N were a bad design decision - they go away in SQLA2, warn now
304 my @numbered_mods = (
307 -and => [a => 10, b => 11],
308 -and2 => [ c => 20, d => 21 ],
310 -nest2 => [ y => 2 ],
311 -or => { m => 7, n => 8 },
312 -or2 => { m => 17, n => 18 },
314 correct => { -and => [
315 -and => [a => 10, b => 11],
316 -and => [ c => 20, d => 21 ],
319 -or => { m => 7, n => 8 },
320 -or => { m => 17, n => 18 },
325 -and2 => [a => 10, b => 11],
326 -and_3 => [ c => 20, d => 21 ],
327 -nest2 => [ x => 1 ],
328 -nest_3 => [ y => 2 ],
329 -or2 => { m => 7, n => 8 },
330 -or_3 => { m => 17, n => 18 },
332 correct => [ -and => [
333 -and => [a => 10, b => 11],
334 -and => [ c => 20, d => 21 ],
337 -or => { m => 7, n => 8 },
338 -or => { m => 17, n => 18 },
343 plan tests => @and_or_tests*3 + @numbered_mods*4;
345 for my $case (@and_or_tests) {
347 local $TODO = $case->{todo} if $case->{todo};
349 local $Data::Dumper::Terse = 1;
352 local $SIG{__WARN__} = sub { push @w, @_ };
353 my $sql = SQL::Abstract->new ($case->{args} || {});
355 my ($stmt, @bind) = $sql->where($case->{where});
362 || diag "Search term:\n" . Dumper $case->{where};
364 is (@w, 0, 'No warnings within and-or tests')
365 || diag join "\n", 'Emitted warnings:', @w;
369 my $w_str = "\QUse of [and|or|nest]_N modifiers is deprecated and will be removed in SQLA v2.0\E";
370 for my $case (@numbered_mods) {
371 local $Data::Dumper::Terse = 1;
374 local $SIG{__WARN__} = sub { push @w, @_ };
375 my $sql = SQL::Abstract->new ($case->{args} || {});
377 my ($old_s, @old_b) = $sql->where($case->{backcompat});
378 my ($new_s, @new_b) = $sql->where($case->{correct});
382 'Backcompat and the correct(tm) syntax result in identical statements',
383 ) || diag "Search terms:\n" . Dumper {
384 backcompat => $case->{backcompat},
385 correct => $case->{correct},
389 ok (@w, 'Warnings were emitted about a mod_N construct');
393 push @non_match, $_ if ($_ !~ /$w_str/);
396 is (@non_match, 0, 'All warnings match the deprecation message')
397 || diag join "\n", 'Rogue warnings:', @non_match;