1 package Object::Remote::ReadChannel;
4 use Scalar::Util qw(weaken);
5 use Object::Remote::Logging qw(:log);
9 is => 'ro', required => 1,
13 log_trace { "Watching filehandle via trigger on 'fh' attribute in Object::Remote::ReadChannel" };
14 Object::Remote->current_loop
17 on_read_ready => sub { $self->_receive_data_from($fh) }
22 has on_close_call => (
23 is => 'rw', default => sub { sub {} },
26 has on_line_call => (is => 'rw');
28 has _receive_data_buffer => (is => 'ro', default => sub { my $x = ''; \$x });
30 #TODO confirmed this is the point of the hang - sysread() is invoked on a
31 #socket inside the controller that blocks and deadlocks the entire system.
32 #The remote nodes are all waiting to receive data at that point.
33 #Validated this behavior exists in an unmodified Object::Remote from CPAN
34 #by wrapping this sysread() with warns that have the pid in them and pounding
35 #my local machine with System::Introspector via ssh and 7 remote perl instances
36 #It looks like one of the futures is responding to an event regarding the ability
37 #to read from a socket and every once in a while an ordering issue means that
38 #there is no actual data to read from the socket
39 sub _receive_data_from {
41 log_trace { "Preparing to read data" };
42 #use Carp qw(cluck); cluck();
43 my $rb = $self->_receive_data_buffer;
44 #TODO is there a specific reason sysread() and syswrite() aren't
45 #a part of ::MiniLoop? It's one spot to handle errors and other
46 #logic involving filehandles
47 #TODO why are the buffers so small? BUFSIZ is usually 32768
48 my $len = sysread($fh, $$rb, 1024, length($$rb));
49 my $err = defined($len) ? '' : ": $!";
50 if (defined($len) and $len > 0) {
51 log_trace { "Read $len bytes of data" };
52 while (my $cb = $self->on_line_call and $$rb =~ s/^(.*)\n//) {
56 log_trace { "Got EOF or error, this read channel is done" };
57 Object::Remote->current_loop
62 $self->on_close_call->($err);
69 log_trace { "read channel is being demolished" };
70 Object::Remote->current_loop