5 RT#67731 - Union types reports spurious parent types -
6 https://rt.cpan.org/Ticket/Display.html?id=67731
8 RT#59478/RT#63000 - 0+ overload causes NV conversion on == on perls before
9 5.14 - this causes comparisons to fail when the number can't fit in an NV
10 without precision loss. I'd like to fix this in a more general way (forcing
11 anyone else who might be using == on tc objects to do weird things isn't very
12 good), although it's hard to test to see what actually works.
14 RT#69839 - UNIVERSAL methods should show up as methods, so things like method
17 === Revise MetaRole API to reunify class/role metaroles:
24 role_attribute => [ ... ],
28 If the $meta is a class, we apply the roles to the class. If it's a role, we
29 hold onto them and apply them as part of applying the role to a class.
31 To make this all work nicely, we'll probably want to track the original role
32 where a method was defined, just like we do with attributes currently. We'll
33 also need to store method modifiers with their original role, which may mean
34 adding some sort of Moose::Meta::Role::MethodModifier class.
36 For each role-specific thing (methods, attributes, etc.) we should allow a
37 role_attribute, role_method, etc. key. The common case will be that the
38 metaroles are intended for the consuming class, but we should allow for
39 metaroles on the role's metaobjects as well.
41 === Deprecate old-style Moose extensions
43 Moose extensions that work by calling Moose->init_meta(metaclass =>
44 'Some::Custom::Metaclass', ...) during their own init_meta should be
45 deprecated, so they can be removed later (this should fix the issues with
46 init_meta generation in Moose::Exporter, see RT51561)
48 === Register implicitly created class/role types
50 When you do has foo => (isa => 'Bar'), it returns a class_type for Bar, but
51 doesn't register it. This means that later you can declare "subtype 'Bar', as
52 'Str', ..." and it'll work, and later instances of the 'Bar' type will use that
53 one. We should register the implicitly created ones so that trying to redefine
54 it after it's used throws an error.
56 === Attributes in roles need to be able to participate in role composition
58 Right now, this fails with no decent workaround:
62 has foo => (is => 'ro');
73 Role attributes really need to be able to participate in role-role combination.
74 This should also fix "with 'Role1', 'Role2'" being broken when Role1 implements
75 a method as an accessor and Role2 requires that method, but at least in that
76 case you can split it into two 'with' statements with minimal loss of
79 === Method modifiers in roles should silently add 'requires' for them
81 This shouldn't be a functionality change, just a better error message (and
82 better introspectability). This shouldn't happen if the role already contains a
83 method by that name, so it'll depend on the previous fix going in (so "has foo
84 => (is => 'ro'); around foo => sub { }" doesn't produce a 'requires' entry).
86 === Add overloading support
88 or at least, don't break existing overloading support
90 This shouldn't treat the overloading stuff as actual methods, since that's just
91 an implementation detail, but we should provide an API for add_overload,
92 get_overload, get_overload_list, etc. In particular, this would allow
93 namespace::autoclean to not break things.
95 Also, MooseX::Role::WithOverloading should probably be cored.
100 === Actual API for metaclass extensions
102 Right now, the only way to bundle multiple metaclass traits is via
103 Moose::Exporter. This is unhelpful if you want to apply the extension to a
104 metaclass object rather than a class you're actually writing. We should come up
105 with an API for doing this.
107 === MooseX::NonMoose in core
109 I think all of the actual issues are solved at this point. The only issue is
110 the (necessary) implementation weirdness - it sets up multiple inheritance
111 between the non-Moose class and Moose::Object, and it installs a custom
112 constructor method at 'extends' time (although perhaps this could be solved by
113 moving some of the logic back into Moose::Object::new?). Other than that, it
114 handles everything transparently as far as I can tell.
116 === Fix attribute and method metaclass compatibility
118 So i got this wrong when rewriting it last year - right now, metaclass compat
119 checks the default attribute and method metaclasses, which is wrong. This means
120 that if a parent class does "use MooseX::FollowPBP", then attributes declared
121 in a subclass will get PBP-style accessors, which is quite surprising.
123 On the other hand, sometimes metaclasses might need to be able to say "I'm
124 going to assume that all of my attributes at least inherit from this custom
125 class", so we might need to split it into "default specified by the user" and
126 "default specified by the metaclass" and only do compat checking on the second?
127 I'm not actually sure this is a valid use case though.
129 Something that probably should be taken into account though is attributes and
130 methods that extend existing attributes or methods from a superclass should
131 inherit the metaclass of the existing one. Also not sure if this is correct,
132 but something to think about.
134 === Rename a bunch of the public API methods
136 Right now the public API is kind of a mess - we have things like get_method vs
137 find_method_by_name (you almost always want to use the latter), there being no
138 has_method equivalent that checks superclasses, get_method_list being public
139 but only returning method names, while _get_local_methods is private (returning
140 method objects), and yet neither of those looks at superclasses, and basically
141 none of this naming follows any kind of consistent pattern.
143 What we really need is a consistent and easy to remember API where the method
144 that people would think to use first is the method that they actually mean.
145 Something like renaming find_method_by_name to find_method, and get_method to
146 find_local_method or something along those lines.
149 == Things to contemplate
151 === Does applying metaroles really need to reinitialize the metaclass?
153 Seems like the logic that's actually necessary is already contained in
154 rebless_instance, and not reinitializing means that existing attributes and
155 methods won't be blown away when metaroles are applied.
157 === Do we want to core namespace::autoclean behavior somehow?
159 This would add Variable::Magic as a required XS dep (not a huge deal at the
160 moment, since Sub::Name is also a required XS dep, but it'd be nice for Moose
161 to be able to be pure perl again at some point in the future, and I'm not sure
162 what the relative chances of Sub::Name vs Variable::Magic making it into core
163 are). If we enabled it by default, this would also break things for people who
164 have introduced Moose into legacy-ish systems where roles are faked using
165 exporters (since those imported methods would be cleaned).
167 If we decide we want this, we may want to core it as an option first ("use
168 Moose -clean" or so), and move to making it the default later.
170 === Fix the error system
174 More specifically, we really want exception objects.
176 === Should using -excludes with a role add 'requires' for excluded methods?
178 It seems to make sense, since otherwise you're violating the role's API
182 == Old todo (does anyone look at this?)
184 -------------------------------------------------------------------------------
186 -------------------------------------------------------------------------------
188 -------------------------------------------------------------------------------
190 -------------------------------------------------------------------------------
192 - DDuncan's Str types
196 => where { Encode::is_utf8( $_[0] ) or $_[0] !~ m/[^0x00-0x7F]/x }
197 => optimize_as { defined($_[0]) && !ref($_[0]) };
201 => where { !Encode::is_utf8( $_[0] ) }
202 => optimize_as { defined($_[0]) && !ref($_[0]) };
206 Add support for doing it with Classes which do not have
207 a type constraint yet created
211 Mostly just for Roles
213 - inherited slot specs
215 'does' can be added to,.. but not changed
216 (need type unions for this)
220 a proxied attribute is an attribute
221 which looks like an attribute,
222 talks like an attribute, smells
223 like an attribute,.. but if you
224 look behind the curtain,.. its
225 over there.. in that other object
227 (... probably be a custom metaclass)
231 [13:16] mst stevan: slight problem with coerce
232 [13:16] mst I only get to declare it once
233 [13:17] mst so if I'm trying to declare it cast-style per-source-class rather than per-target-class
234 [13:17] mst I am extremely screwed
236 [13:17] stevan they are not class specific
237 [13:18] stevan they are attached to the type constraint itself
238 [13:18] * stevan ponders anon-coercion-metaobjects
239 [13:18] mst yes, that's fine
240 [13:19] mst but when I declare a class
241 [13:19] mst I want to be able to say "this class coerces to X type via <this>"
242 [13:19] stevan yeah something like that
243 [13:19] stevan oh,.. hmm
244 [13:20] stevan sort of like inflate/deflate?
245 [13:20] stevan around the accessors?
246 [13:25] * bluefeet has quit (Remote host closed the connection)
248 [13:27] mst nothing like that
249 [13:27] mst like a cast
250 [13:31] mst stevan: $obj->foo($bar); where 'foo' expects a 'Foo' object
251 [13:31] mst stevan: is effectively <Foo>$bar, right?
252 [13:32] mst stevan: I want to be able to say in package Bar
253 [13:32] mst stevan: coerce_to 'Foo' via { ... };
257 -----------------------------------------------------------
258 -- Type Constraints refactor
259 -----------------------------------------------------------
261 - add support for locally scoped TC
263 This would borrow from MooseX::TypeLibrary to prefix the TC with the name
264 of the package. It would then be accesible from the outside as the fully
265 scoped name, but the local attributes would use it first. (this would need support
266 in the registry for this).
268 - look into sugar extensions
270 Use roles as sugar layer function providers (ala MooseX::AttributeHelpers). This
271 would allow custom metaclasses to provide roles to extend the sugar syntax with.
273 (NOTE: Talk to phaylon a bit more on this)
275 - allow a switch of some kind to optionally turn TC checking off at runtime
277 The type checks can get expensive and some people have suggested that allowing
278 the checks to be turned off would be helpful for deploying into performance
279 intensive systems. Perhaps this can actually be done as an option to make_immutable?
283 * make the errors for TCs use ->message
284 * look into localizing the messages too
285 * make ANON TCs be lazy, so they can possibly be subsituted for the real thing later
286 * make ANON TCs more introspectable
294 where { (/[a-z][a-z0-9]+/i or fail('Invalid character(s)'))
295 and (length($_) >= 5 or fail('Too short (less than 5 chars)'))
297 on_fail { MyException->throw(value => $_[0], message => $_[1]) };
299 # fail() will just return false unless the call is made via
300 $tc->check_or_fail($value);
302 * and then something like this:
304 subtype Foo => as Bar => where { ... } => scoped => -global;
305 subtype Foo => as Bar => where { ... } => scoped => -local;
309 subtype Foo => as Bar => where { ... } => in __PACKAGE__ ;
311 # or (not sure if it would be possible)
313 my $Foo = subtype Bar => where { ... };
317 [17:10] <autarch> stevan: it should do it if I pass coerce => 1 as part of the attribute definition
318 [17:12] <stevan> autarch: what I am not 100% sure of is how to tell it to deep coerce and when to not
319 [17:13] <stevan> cause a basic coerce is from A to B
320 [17:13] <autarch> hmm
321 [17:13] <stevan> which is valid for collection types too
322 [17:13] <stevan> deep coercion is what you are asking for
323 [17:13] <autarch> yeah
324 [17:13] <stevan> so perhaps we add deep_coerce => 1
325 [17:13] <stevan> which will do it
326 [17:13] <autarch> that's fine for me
329 coerce_deeply => 1 # reads better
331 -------------------------------------------------------------------------------
333 -------------------------------------------------------------------------------
335 - rationalize all the get_X methods for classes (and roles)
337 We have get_attribute, get_attributes_list, get_all_attributes,
338 etc. First, we need to make the method names consistent. If something
339 returns an attribute vs a name, that needs to be clear from the method
340 name. We also need to make sure that local vs. "entire inheritance
341 chain" is clear from the name.
343 This is mostly a CMOP change.
345 - Metaclass constructors
347 There's a _lot_ of different conventions in here. Some things to consider:
350 * allowing new( 'name', %args ) vs ( name => 'name', %args )
351 * Method->wrap vs Method->new
353 - Moose::Meta::TypeConstraint::Parameter{izable,ized}
355 The relationship between these two classes is very odd. In particular,
356 this line in Parameterized is insane:
358 foreach my $type (Moose::Util::TypeConstraints::get_all_parameterizable_types()) {
360 Why does it need to loop through all parameterizable types? Shouldn't
361 it know which parameterizable type it "came from"?
363 - Moose::Util::TypeConstraints vs Moose::Meta::Type{Coercion,Constraint}
365 The Util module has _way_ too much functionality. It needs to be
366 refactored so it's a thin sugar layer on top of the meta API. As it
367 stands now, it does things like parse type names (and determine if
368 they're valid), manage the registry, and much more.
370 - Anything with a _(meta)?class method
372 Every method that returns a class name needs to become a rw attribute
373 that can be set via the constructor.
375 - The Moose::Error stuff
377 This is sort of half-implemented. We still use Carp directly, and the
378 internals can't decide how to throw an error (is it
379 Moose->throw_error, __PACKAGE__->throw_error, what?).
381 The internals need to be made consistent before we expose this to the
384 -------------------------------------------------------------------------------
386 -------------------------------------------------------------------------------
388 - Moose "strict" mode
390 use Moose 'strict'; This would allow us to have all sort of expensive tests
391 which can be turned off in prod.
393 - Moose::Philosophy.pod
395 To explain Moose from a very high level
399 We certainly have enough meta-information to make pretty complete POD docs.