Commit | Line | Data |
ff1234ad |
1 | use strict; |
2 | use warnings; |
3 | |
4 | use lib qw(t/lib); |
5 | use Test::More; |
6 | use Test::Exception; |
31073ac7 |
7 | |
1b658919 |
8 | # MASSIVE FIXME - there is a hole in ::RSC / as_subselect_rs |
9 | # losing the order. Needs a rework/extract of the realiaser, |
10 | # and that's a whole another bag of dicks |
11 | BEGIN { $ENV{DBIC_SHUFFLE_UNORDERED_RESULTSETS} = 0 } |
12 | |
31073ac7 |
13 | use DBICTest::Schema::CD; |
14 | BEGIN { |
15 | # the default scalarref table name will not work well for this test |
16 | DBICTest::Schema::CD->table('cd'); |
17 | } |
18 | |
ff1234ad |
19 | use DBICTest; |
20 | |
be64931c |
21 | my $schema = DBICTest->init_schema; |
22 | |
ff1234ad |
23 | my $tkfks = $schema->resultset('FourKeys_to_TwoKeys'); |
24 | |
fd8076c8 |
25 | my ($fa, $fb, $fc) = $tkfks->related_resultset ('fourkeys')->populate ([ |
ff1234ad |
26 | [qw/foo bar hello goodbye sensors read_count/], |
27 | [qw/1 1 1 1 a 10 /], |
28 | [qw/2 2 2 2 b 20 /], |
fd8076c8 |
29 | [qw/1 1 1 2 c 30 /], |
ff1234ad |
30 | ]); |
31 | |
32 | # This is already provided by DBICTest |
33 | #my ($ta, $tb) = $tkfk->related_resultset ('twokeys')->populate ([ |
34 | # [qw/artist cd /], |
35 | # [qw/1 1 /], |
36 | # [qw/2 2 /], |
37 | #]); |
38 | my ($ta, $tb) = $schema->resultset ('TwoKeys') |
1b658919 |
39 | ->search ( [ { artist => 1, cd => 1 }, { artist => 2, cd => 2 } ], { order_by => 'artist' }) |
ff1234ad |
40 | ->all; |
41 | |
42 | my $tkfk_cnt = $tkfks->count; |
43 | |
44 | my $non_void_ctx = $tkfks->populate ([ |
45 | { autopilot => 'a', fourkeys => $fa, twokeys => $ta, pilot_sequence => 10 }, |
46 | { autopilot => 'b', fourkeys => $fb, twokeys => $tb, pilot_sequence => 20 }, |
47 | { autopilot => 'x', fourkeys => $fa, twokeys => $tb, pilot_sequence => 30 }, |
48 | { autopilot => 'y', fourkeys => $fb, twokeys => $ta, pilot_sequence => 40 }, |
49 | ]); |
50 | is ($tkfks->count, $tkfk_cnt += 4, 'FourKeys_to_TwoKeys populated succesfully'); |
51 | |
52 | # |
53 | # Make sure the forced group by works (i.e. the joining does not cause double-updates) |
54 | # |
55 | |
56 | # create a resultset matching $fa and $fb only |
fd8076c8 |
57 | my $fks = $schema->resultset ('FourKeys')->search ( |
58 | { |
59 | sensors => { '!=', 'c' }, |
60 | ( map { $_ => [1, 2] } qw/foo bar hello goodbye/ ), |
eb58c082 |
61 | }, { join => { fourkeys_to_twokeys => 'twokeys' }} |
fd8076c8 |
62 | ); |
ff1234ad |
63 | |
64 | is ($fks->count, 4, 'Joined FourKey count correct (2x2)'); |
2cfc22dd |
65 | $schema->is_executed_sql_bind( sub { |
66 | $fks->update ({ read_count => \ 'read_count + 1' }) |
67 | }, [[ |
be64931c |
68 | 'UPDATE fourkeys |
69 | SET read_count = read_count + 1 |
fd8076c8 |
70 | WHERE ( ( ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? ) ) |
71 | ', |
2cfc22dd |
72 | (1, 2) x 4, |
73 | 'c', |
74 | ]], 'Correct update-SQL with multijoin with pruning' ); |
fd8076c8 |
75 | |
76 | is ($fa->discard_changes->read_count, 11, 'Update ran only once on discard-join resultset'); |
77 | is ($fb->discard_changes->read_count, 21, 'Update ran only once on discard-join resultset'); |
78 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
79 | |
80 | # make the multi-join stick |
1b658919 |
81 | my $fks_multi = $fks->search( |
82 | { 'fourkeys_to_twokeys.pilot_sequence' => { '!=' => 666 } }, |
83 | { order_by => [ $fks->result_source->primary_columns ] }, |
84 | ); |
2cfc22dd |
85 | $schema->is_executed_sql_bind( sub { |
86 | $fks_multi->update ({ read_count => \ 'read_count + 1' }) |
87 | }, [ |
88 | [ 'BEGIN' ], |
89 | [ |
90 | 'SELECT me.foo, me.bar, me.hello, me.goodbye |
91 | FROM fourkeys me |
92 | LEFT JOIN fourkeys_to_twokeys fourkeys_to_twokeys |
93 | ON fourkeys_to_twokeys.f_bar = me.bar AND fourkeys_to_twokeys.f_foo = me.foo AND fourkeys_to_twokeys.f_goodbye = me.goodbye AND fourkeys_to_twokeys.f_hello = me.hello |
94 | WHERE ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND fourkeys_to_twokeys.pilot_sequence != ? AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? |
95 | GROUP BY me.foo, me.bar, me.hello, me.goodbye |
1b658919 |
96 | ORDER BY foo, bar, hello, goodbye |
2cfc22dd |
97 | ', |
98 | (1, 2) x 2, |
99 | 666, |
100 | (1, 2) x 2, |
101 | 'c', |
102 | ], |
103 | [ |
104 | 'UPDATE fourkeys |
105 | SET read_count = read_count + 1 |
106 | WHERE ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? ) OR ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? ) |
107 | ', |
108 | ( (1) x 4, (2) x 4 ), |
109 | ], |
110 | [ 'COMMIT' ], |
111 | ], 'Correct update-SQL with multijoin without pruning' ); |
ff1234ad |
112 | |
fd8076c8 |
113 | is ($fa->discard_changes->read_count, 12, 'Update ran only once on joined resultset'); |
114 | is ($fb->discard_changes->read_count, 22, 'Update ran only once on joined resultset'); |
115 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
be64931c |
116 | |
31160673 |
117 | $schema->is_executed_sql_bind( sub { |
118 | my $res = $fks_multi->search (\' "blah" = "bleh" ')->delete; |
119 | ok ($res, 'operation is true'); |
120 | cmp_ok ($res, '==', 0, 'zero rows affected'); |
121 | }, [ |
122 | [ 'BEGIN' ], |
123 | [ |
124 | 'SELECT me.foo, me.bar, me.hello, me.goodbye |
125 | FROM fourkeys me |
126 | LEFT JOIN fourkeys_to_twokeys fourkeys_to_twokeys |
127 | ON fourkeys_to_twokeys.f_bar = me.bar AND fourkeys_to_twokeys.f_foo = me.foo AND fourkeys_to_twokeys.f_goodbye = me.goodbye AND fourkeys_to_twokeys.f_hello = me.hello |
128 | WHERE "blah" = "bleh" AND ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND fourkeys_to_twokeys.pilot_sequence != ? AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? |
129 | GROUP BY me.foo, me.bar, me.hello, me.goodbye |
1b658919 |
130 | ORDER BY foo, bar, hello, goodbye |
31160673 |
131 | ', |
132 | (1, 2) x 2, |
133 | 666, |
134 | (1, 2) x 2, |
135 | 'c', |
136 | ], |
137 | [ 'COMMIT' ], |
138 | ], 'Correct null-delete-SQL with multijoin without pruning' ); |
139 | |
140 | |
be64931c |
141 | # try the same sql with forced multicolumn in |
2cfc22dd |
142 | $schema->is_executed_sql_bind( sub { |
143 | local $schema->storage->{_use_multicolumn_in} = 1; |
144 | |
145 | # this can't actually execute on sqlite |
146 | eval { $fks_multi->update ({ read_count => \ 'read_count + 1' }) }; |
147 | }, [[ |
be64931c |
148 | 'UPDATE fourkeys |
149 | SET read_count = read_count + 1 |
150 | WHERE ( |
151 | (foo, bar, hello, goodbye) IN ( |
152 | SELECT me.foo, me.bar, me.hello, me.goodbye |
153 | FROM fourkeys me |
fd8076c8 |
154 | LEFT JOIN fourkeys_to_twokeys fourkeys_to_twokeys ON |
155 | fourkeys_to_twokeys.f_bar = me.bar |
156 | AND fourkeys_to_twokeys.f_foo = me.foo |
157 | AND fourkeys_to_twokeys.f_goodbye = me.goodbye |
158 | AND fourkeys_to_twokeys.f_hello = me.hello |
8d005ad9 |
159 | WHERE ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND fourkeys_to_twokeys.pilot_sequence != ? AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? |
1b658919 |
160 | ORDER BY foo, bar, hello, goodbye |
be64931c |
161 | ) |
162 | ) |
163 | ', |
2cfc22dd |
164 | ( 1, 2) x 2, |
165 | 666, |
166 | ( 1, 2) x 2, |
167 | 'c', |
168 | ]], 'Correct update-SQL with multicolumn in support' ); |
169 | |
170 | $schema->is_executed_sql_bind( sub { |
171 | $fks->search({ 'twokeys.artist' => { '!=' => 666 } })->update({ read_count => \ 'read_count + 1' }); |
172 | }, [ |
173 | [ 'BEGIN' ], |
fd8076c8 |
174 | [ |
2cfc22dd |
175 | 'SELECT me.foo, me.bar, me.hello, me.goodbye |
176 | FROM fourkeys me |
177 | LEFT JOIN fourkeys_to_twokeys fourkeys_to_twokeys |
178 | ON fourkeys_to_twokeys.f_bar = me.bar AND fourkeys_to_twokeys.f_foo = me.foo AND fourkeys_to_twokeys.f_goodbye = me.goodbye AND fourkeys_to_twokeys.f_hello = me.hello |
179 | LEFT JOIN twokeys twokeys |
180 | ON twokeys.artist = fourkeys_to_twokeys.t_artist AND twokeys.cd = fourkeys_to_twokeys.t_cd |
181 | WHERE ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? AND twokeys.artist != ? |
182 | GROUP BY me.foo, me.bar, me.hello, me.goodbye |
183 | ', |
184 | (1, 2) x 4, |
185 | 'c', |
186 | 666, |
fd8076c8 |
187 | ], |
2cfc22dd |
188 | [ |
189 | 'UPDATE fourkeys |
190 | SET read_count = read_count + 1 |
191 | WHERE ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? ) OR ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? ) |
192 | ', |
193 | ( (1) x 4, (2) x 4 ), |
194 | ], |
195 | [ 'COMMIT' ], |
196 | ], 'Correct update-SQL with premultiplied restricting join without pruning' ); |
eb58c082 |
197 | |
198 | is ($fa->discard_changes->read_count, 13, 'Update ran only once on joined resultset'); |
199 | is ($fb->discard_changes->read_count, 23, 'Update ran only once on joined resultset'); |
200 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
201 | |
ff1234ad |
202 | # |
be64931c |
203 | # Make sure multicolumn in or the equivalent functions correctly |
ff1234ad |
204 | # |
205 | |
206 | my $sub_rs = $tkfks->search ( |
207 | [ |
208 | { map { $_ => 1 } qw/artist.artistid cd.cdid fourkeys.foo fourkeys.bar fourkeys.hello fourkeys.goodbye/ }, |
209 | { map { $_ => 2 } qw/artist.artistid cd.cdid fourkeys.foo fourkeys.bar fourkeys.hello fourkeys.goodbye/ }, |
210 | ], |
211 | { |
212 | join => [ 'fourkeys', { twokeys => [qw/artist cd/] } ], |
213 | }, |
214 | ); |
215 | |
216 | is ($sub_rs->count, 2, 'Only two rows from fourkeys match'); |
217 | |
218 | # attempts to delete a grouped rs should fail miserably |
219 | throws_ok ( |
220 | sub { $sub_rs->search ({}, { distinct => 1 })->delete }, |
221 | qr/attempted a delete operation on a resultset which does group_by/, |
222 | 'Grouped rs update/delete not allowed', |
223 | ); |
224 | |
225 | # grouping on PKs only should pass |
af668ad6 |
226 | $sub_rs->search ( |
227 | {}, |
228 | { |
be64931c |
229 | group_by => [ reverse $sub_rs->result_source->primary_columns ], # reverse to make sure the PK-list comparison works |
af668ad6 |
230 | }, |
231 | )->update ({ pilot_sequence => \ 'pilot_sequence + 1' }); |
ff1234ad |
232 | |
233 | is_deeply ( |
234 | [ $tkfks->search ({ autopilot => [qw/a b x y/]}, { order_by => 'autopilot' }) |
8273e845 |
235 | ->get_column ('pilot_sequence')->all |
ff1234ad |
236 | ], |
237 | [qw/11 21 30 40/], |
238 | 'Only two rows incremented', |
239 | ); |
240 | |
af668ad6 |
241 | # also make sure weird scalarref usage works (RT#51409) |
242 | $tkfks->search ( |
243 | \ 'pilot_sequence BETWEEN 11 AND 21', |
244 | )->update ({ pilot_sequence => \ 'pilot_sequence + 1' }); |
245 | |
246 | is_deeply ( |
247 | [ $tkfks->search ({ autopilot => [qw/a b x y/]}, { order_by => 'autopilot' }) |
8273e845 |
248 | ->get_column ('pilot_sequence')->all |
af668ad6 |
249 | ], |
250 | [qw/12 22 30 40/], |
251 | 'Only two rows incremented (where => scalarref works)', |
252 | ); |
253 | |
59ac6523 |
254 | { |
255 | my $rs = $schema->resultset('FourKeys_to_TwoKeys')->search ( |
256 | { |
257 | -or => [ |
258 | { 'me.pilot_sequence' => 12 }, |
259 | { 'me.autopilot' => 'b' }, |
260 | ], |
261 | } |
262 | ); |
263 | lives_ok { $rs->update({ autopilot => 'z' }) } |
264 | 'Update with table name qualifier in -or conditions lives'; |
265 | is_deeply ( |
266 | [ $tkfks->search ({ pilot_sequence => [12, 22]}) |
267 | ->get_column ('autopilot')->all |
268 | ], |
269 | [qw/z z/], |
270 | '... and yields the right data', |
271 | ); |
272 | } |
273 | |
274 | |
ff1234ad |
275 | $sub_rs->delete; |
ff1234ad |
276 | is ($tkfks->count, $tkfk_cnt -= 2, 'Only two rows deleted'); |
fef47a8e |
277 | |
278 | # make sure limit-only deletion works |
279 | cmp_ok ($tkfk_cnt, '>', 1, 'More than 1 row left'); |
280 | $tkfks->search ({}, { rows => 1 })->delete; |
281 | is ($tkfks->count, $tkfk_cnt -= 1, 'Only one row deleted'); |
282 | |
887d8da0 |
283 | |
fd8076c8 |
284 | # check with sql-equality, as sqlite will accept most bad sql just fine |
fd8076c8 |
285 | { |
286 | my $rs = $schema->resultset('CD')->search( |
287 | { 'me.year' => { '!=' => 2010 } }, |
288 | ); |
289 | |
2cfc22dd |
290 | $schema->is_executed_sql_bind( sub { |
291 | $rs->search({}, { join => 'liner_notes' })->delete; |
292 | }, [[ |
fd8076c8 |
293 | 'DELETE FROM cd WHERE ( year != ? )', |
2cfc22dd |
294 | 2010, |
295 | ]], 'Non-restricting multijoins properly thrown out' ); |
fd8076c8 |
296 | |
2cfc22dd |
297 | $schema->is_executed_sql_bind( sub { |
298 | $rs->search({}, { prefetch => 'liner_notes' })->delete; |
299 | }, [[ |
fd8076c8 |
300 | 'DELETE FROM cd WHERE ( year != ? )', |
2cfc22dd |
301 | 2010, |
302 | ]], 'Non-restricting multiprefetch thrown out' ); |
fd8076c8 |
303 | |
2cfc22dd |
304 | $schema->is_executed_sql_bind( sub { |
305 | $rs->search({}, { prefetch => 'artist' })->delete; |
306 | }, [[ |
fd8076c8 |
307 | 'DELETE FROM cd WHERE ( cdid IN ( SELECT me.cdid FROM cd me JOIN artist artist ON artist.artistid = me.artist WHERE ( me.year != ? ) ) )', |
2cfc22dd |
308 | 2010, |
309 | ]], 'Restricting prefetch left in, selector thrown out'); |
fd8076c8 |
310 | |
2cfc22dd |
311 | ### switch artist and cd to fully qualified table names |
312 | ### make sure nothing is stripped out |
554f3621 |
313 | my $cd_rsrc = $schema->source('CD'); |
314 | $cd_rsrc->name('main.cd'); |
315 | $cd_rsrc->relationship_info($_)->{attrs}{cascade_delete} = 0 |
316 | for $cd_rsrc->relationships; |
317 | |
318 | my $art_rsrc = $schema->source('Artist'); |
319 | $art_rsrc->name(\'main.artist'); |
320 | $art_rsrc->relationship_info($_)->{attrs}{cascade_delete} = 0 |
321 | for $art_rsrc->relationships; |
322 | |
2cfc22dd |
323 | $schema->is_executed_sql_bind( sub { |
324 | $rs->delete |
325 | }, [[ |
326 | 'DELETE FROM main.cd WHERE year != ?', |
327 | 2010, |
328 | ]], 'delete with fully qualified table name' ); |
554f3621 |
329 | |
330 | $rs->create({ title => 'foo', artist => 1, year => 2000 }); |
2cfc22dd |
331 | $schema->is_executed_sql_bind( sub { |
332 | $rs->delete_all |
333 | }, [ |
334 | [ 'BEGIN' ], |
335 | [ |
336 | 'SELECT me.cdid, me.artist, me.title, me.year, me.genreid, me.single_track FROM main.cd me WHERE me.year != ?', |
337 | 2010, |
338 | ], |
339 | [ |
340 | 'DELETE FROM main.cd WHERE ( cdid = ? )', |
341 | 1, |
342 | ], |
343 | [ 'COMMIT' ], |
344 | ], 'delete_all with fully qualified table name' ); |
554f3621 |
345 | |
346 | $rs->create({ cdid => 42, title => 'foo', artist => 2, year => 2000 }); |
2cfc22dd |
347 | my $cd42 = $rs->find(42); |
348 | |
349 | $schema->is_executed_sql_bind( sub { |
350 | $cd42->delete |
351 | }, [[ |
352 | 'DELETE FROM main.cd WHERE cdid = ?', |
353 | 42, |
354 | ]], 'delete of object from table with fully qualified name' ); |
355 | |
356 | $schema->is_executed_sql_bind( sub { |
357 | $cd42->related_resultset('artist')->delete |
358 | }, [[ |
554f3621 |
359 | 'DELETE FROM main.artist WHERE ( artistid IN ( SELECT me.artistid FROM main.artist me WHERE ( me.artistid = ? ) ) )', |
2cfc22dd |
360 | 2, |
361 | ]], 'delete of related object from scalarref fully qualified named table' ); |
362 | |
363 | my $art3 = $schema->resultset('Artist')->find(3); |
554f3621 |
364 | |
2cfc22dd |
365 | $schema->is_executed_sql_bind( sub { |
366 | $art3->related_resultset('cds')->delete; |
367 | }, [[ |
554f3621 |
368 | 'DELETE FROM main.cd WHERE ( artist = ? )', |
2cfc22dd |
369 | 3, |
370 | ]], 'delete of related object from fully qualified named table' ); |
fd8076c8 |
371 | |
2cfc22dd |
372 | $schema->is_executed_sql_bind( sub { |
373 | $art3->cds_unordered->delete; |
374 | }, [[ |
554f3621 |
375 | 'DELETE FROM main.cd WHERE ( artist = ? )', |
2cfc22dd |
376 | 3, |
377 | ]], 'delete of related object from fully qualified named table via relaccessor' ); |
554f3621 |
378 | |
2cfc22dd |
379 | $schema->is_executed_sql_bind( sub { |
380 | $rs->search({}, { prefetch => 'artist' })->delete; |
381 | }, [[ |
554f3621 |
382 | 'DELETE FROM main.cd WHERE ( cdid IN ( SELECT me.cdid FROM main.cd me JOIN main.artist artist ON artist.artistid = me.artist WHERE ( me.year != ? ) ) )', |
2cfc22dd |
383 | 2010, |
384 | ]], 'delete with fully qualified table name and subquery correct' ); |
fd8076c8 |
385 | |
31073ac7 |
386 | # check that as_subselect_rs works ok |
387 | # inner query is untouched, then a selector |
388 | # and an IN condition |
2cfc22dd |
389 | $schema->is_executed_sql_bind( sub { |
390 | $schema->resultset('CD')->search({ |
391 | 'me.cdid' => 1, |
392 | 'artist.name' => 'partytimecity', |
393 | }, { |
394 | join => 'artist', |
395 | })->as_subselect_rs->delete; |
396 | }, [[ |
31073ac7 |
397 | ' |
554f3621 |
398 | DELETE FROM main.cd |
31073ac7 |
399 | WHERE ( |
400 | cdid IN ( |
401 | SELECT me.cdid |
402 | FROM ( |
403 | SELECT me.cdid, me.artist, me.title, me.year, me.genreid, me.single_track |
554f3621 |
404 | FROM main.cd me |
405 | JOIN main.artist artist ON artist.artistid = me.artist |
31073ac7 |
406 | WHERE artist.name = ? AND me.cdid = ? |
407 | ) me |
408 | ) |
409 | ) |
410 | ', |
2cfc22dd |
411 | 'partytimecity', |
412 | 1, |
413 | ]], 'Delete from as_subselect_rs works correctly' ); |
fd8076c8 |
414 | } |
887d8da0 |
415 | |
fef47a8e |
416 | done_testing; |