add sliced and diced conversation re design from IRC
[p5sagit/Log-Contextual.git] / lib / Log / Contextual.pm
CommitLineData
0daa11f3 1package Log::Contextual;
2
31;
0a3750e2 4
5__END__
6
7.:12:44:33:. <@mst> we have a $Get_Logger global that contains a subref
8.:12:45:11:. <@mst> sub log_debug (&) { my $log = $Get_Logger->(); if ($log->is_debug) {
9 $log->debug($_[0]->()} } }
10.:13:01:22:. >>@mst<< frew: the other part is we'll need a set_logger function that's global
11.:13:01:26:. >>@mst<< frew: plus a with_logger function
12.:13:01:33:. >>@mst<< frew: that uses local()
13.:13:01:38:. <@mst> that should be enough to make a start
14.:13:01:48:. <@frew> so with_logger is what gives us context?
15.:13:01:57:. <@mst> right
16.:13:02:09:. <@mst> with_logger { $logger }, sub { <run code> };
17.:13:02:29:. <@mst> sub with_logger { local $Get_Logger = $_[0]; $_[1]->() }
18.:13:03:05:. <@mst> amazing how simple this stuff is once you get the paradigm
19.:13:03:13:. <@mst> also consider
20.:13:04:17:. <@mst> package Catalyst::Plugin::LogContextual; use Moose::Role; around
21 handle_request => sub { my ($orig, $self) = (shift, shift); my @args = @_;
22 with_logger { $self->log } sub { $self->$orig(@args) } };
23.:13:03:43:. <@frew> so why is $G_L a subref instead of just a ref? to allow for lazy
24 instantiation or what?
25.:13:06:37:. <@mst> it does the caller introspection there IIRC
26.:13:09:56:. <@mst> I've spent like a year thinking about how to do logging sanely
27.:13:10:17:. <@mst> having it turn out to be this bloody trivial to implement amuses me
28.:13:10:43:. <@frew> mst: I guess that's why thinking about it for a year is worth it :-)
29.:13:12:01:. <@mst> there's a couple other things we'll want, I suspect
30.:13:12:18:. <@mst> like a concept of depth and a category system separate from the logger
31.:13:12:24:. <@mst> but those can be handled later atop this API
32.:13:13:35:. <@frew> so like, logging from the model, logging from the controller, logging from
33 the DBIDS part of the model vs the DBIC part of the model ?
34.:13:14:13:. <@mst> that sort of thing
35.:13:14:20:. <@mst> how much of that we can delegate to the logger I dunno yet
36