Commit | Line | Data |
7e54e579 |
1 | package Gitalist::View::SyntaxHighlight; |
2 | use Moose; |
3 | use Gitalist; # ->path_to |
4 | use namespace::autoclean; |
5 | |
6 | extends 'Catalyst::View'; |
7 | |
8 | use Syntax::Highlight::Engine::Kate (); |
9 | use Syntax::Highlight::Engine::Kate::Perl (); |
10 | |
c8870bd3 |
11 | use HTML::Entities qw(encode_entities); |
12 | |
f5da8e7a |
13 | =begin |
14 | |
15 | B<Notes> |
16 | |
17 | What should be done, but isn't currently: |
18 | |
19 | broquaint> Another Cat question - if I want to have arbitrary things highlighted is pushing things through a View at all costs terribly wrong? |
20 | broquaint> e.g modifying this slightly to highlight anything (or arrays of anything) http://github.com/broquaint/Gitalist/blob/a7cc1ede5f9729465bb53da9c3a8b300a3aa8a0a/lib/Gitalist/View/SyntaxHighlight.pm |
21 | t0m> no, that's totally fine.. I'd tend to push the rendering logic into a model, so you end up doing something like: $c->model('SyntaxDriver')->highlight_all($stuff, $c->view('SyntaxHighlight')); |
22 | broquaint> I'm thinking it's a bad idea because the Controller needs to munge data such that the View knows what to do |
23 | broquaint> You just blew my mind ;) |
24 | t0m> ^^ That works _much_ better if you split up your view methods into process & render.. |
25 | t0m> ala TT.. |
26 | t0m> i.e. I'd have 'highlight this scalar' as the ->render method in the view.. |
27 | t0m> And then the 'default' thing (i.e. process method) will do that and shove the output in the body.. |
28 | t0m> but then you can write foreach my $thing (@things) { push(@highlighted_things, $c->view('SyntaxHighlight')->render($thing)); } |
29 | t0m> and then I'd move that ^^ loop down into a model which actually knows about / abstracts walking the data structures concerned.. |
30 | t0m> But splitting render and process is the most important bit.. :) Otherwise you need to jump through hoops to render things that don't fit 'nicely' into the bits of stash / body that the view uses by 'default' |
31 | t0m> I wouldn't kill you for putting the structure walking code in the view given you're walking simple arrays / hashes.. It becomes more important if you have a more complex visitor.. |
32 | t0m> (I use Visitor in the design patterns sense) |
33 | t0m> As the visitor is responsible for walking the structure, delegating to the ->render call in the view which is responsible for actually mangling the content.. |
34 | |
35 | =cut |
36 | |
7e54e579 |
37 | sub process { |
38 | my($self, $c) = @_; |
c8870bd3 |
39 | |
f5da8e7a |
40 | for($c->stash->{blobs} ? @{$c->stash->{blobs}} : $c->stash->{blob}) { |
41 | $_ = $self->highlight($c->stash->{language} => $_); |
42 | } |
43 | |
44 | $c->forward('View::Default'); |
45 | } |
46 | |
ad8884fc |
47 | # XXX This takes for freakin' ever on big merges. A cache may be needed. |
f5da8e7a |
48 | sub highlight { |
49 | my($self, $lang, $blob) = @_; |
50 | |
6cf4366a |
51 | my $ret; |
f5da8e7a |
52 | if($lang) { |
6cf4366a |
53 | # via http://github.com/jrockway/angerwhale/blob/master/lib/Angerwhale/Format/Pod.pm#L136 |
54 | $ret = eval { |
c8870bd3 |
55 | no warnings 'redefine'; |
56 | local *Syntax::Highlight::Engine::Kate::Template::logwarning |
57 | = sub { die @_ }; # i really don't care |
58 | my $hl = Syntax::Highlight::Engine::Kate->new( |
f5da8e7a |
59 | language => $lang, |
c8870bd3 |
60 | substitutions => { |
61 | "<" => "<", |
62 | ">" => ">", |
63 | "&" => "&", |
64 | q{'} => "'", |
65 | q{"} => """, |
66 | }, |
67 | format_table => { |
68 | # convert Kate's internal representation into |
69 | # <span class="<internal name>"> value </span> |
70 | map { |
71 | $_ => [ qq{<span class="$_">}, '</span>' ] |
72 | } |
73 | qw/Alert BaseN BString Char Comment DataType |
74 | DecVal Error Float Function IString Keyword |
75 | Normal Operator Others RegionMarker Reserved |
76 | String Variable Warning/, |
77 | }, |
78 | ); |
79 | |
f5da8e7a |
80 | $hl->highlightText($blob); |
c8870bd3 |
81 | }; |
82 | warn $@ if $@; |
c8870bd3 |
83 | } |
6cf4366a |
84 | |
85 | return $ret || encode_entities($blob); |
7e54e579 |
86 | } |
87 | |
1ef8dc7d |
88 | __PACKAGE__->meta->make_immutable; |